chore(lib/modules/finders/lookup): warn for bad filters without uninitalized modules

This commit is contained in:
PalmDevs 2025-10-27 00:35:40 +07:00
parent c8906b442a
commit dde81af9f6
No known key found for this signature in database
GPG key ID: 6FAE8F8677ACA8BA

View file

@ -157,6 +157,13 @@ export function lookupModules<
>(filter: F, options: O): Generator<LookupModulesResult<F, O>, undefined>
export function* lookupModules(filter: Filter, options?: LookupModulesOptions) {
if (
__DEV__ &&
filter.key.includes('revenge.deps') &&
!(options?.uninitialized ?? false)
)
DEBUG_warnFilterWithoutUninitialized(filter.key)
let notFound = true
let cached: Set<Metro.ModuleID> | undefined
@ -304,6 +311,13 @@ export function lookupModule<
>(filter: F, options: O): LookupModulesResult<F, O> | LookupNotFoundResult
export function lookupModule(filter: Filter, options?: LookupModulesOptions) {
if (
__DEV__ &&
filter.key.includes('revenge.deps') &&
!(options?.uninitialized ?? false)
)
DEBUG_warnFilterWithoutUninitialized(filter.key)
if (options?.cached ?? true) {
const notInit = !(options?.initialize ?? true)
@ -464,3 +478,15 @@ function DEBUG_warnLookupNoMatch(key: string) {
nativeLoggingHook(`\u001b[31mFailed lookup: ${key}\n${stack}\u001b[0m`, 2)
}
/**
* Warns the developer about a potentially bad filter for lookups that do not have uninitialized modules.
*/
function DEBUG_warnFilterWithoutUninitialized(key: string) {
const stack = getCurrentStack()
nativeLoggingHook(
`\u001b[33mPotentially bad filter without uninitialized modules lookup: ${key}\n${stack}\u001b[0m`,
2,
)
}