From dde81af9f675846ec6d7670f4f2b664d510363c0 Mon Sep 17 00:00:00 2001 From: PalmDevs Date: Mon, 27 Oct 2025 00:35:40 +0700 Subject: [PATCH] chore(lib/modules/finders/lookup): warn for bad filters without uninitalized modules --- lib/modules/src/finders/lookup.ts | 26 ++++++++++++++++++++++++++ 1 file changed, 26 insertions(+) diff --git a/lib/modules/src/finders/lookup.ts b/lib/modules/src/finders/lookup.ts index 03ed9ce..0835cab 100644 --- a/lib/modules/src/finders/lookup.ts +++ b/lib/modules/src/finders/lookup.ts @@ -157,6 +157,13 @@ export function lookupModules< >(filter: F, options: O): Generator, undefined> export function* lookupModules(filter: Filter, options?: LookupModulesOptions) { + if ( + __DEV__ && + filter.key.includes('revenge.deps') && + !(options?.uninitialized ?? false) + ) + DEBUG_warnFilterWithoutUninitialized(filter.key) + let notFound = true let cached: Set | undefined @@ -304,6 +311,13 @@ export function lookupModule< >(filter: F, options: O): LookupModulesResult | LookupNotFoundResult export function lookupModule(filter: Filter, options?: LookupModulesOptions) { + if ( + __DEV__ && + filter.key.includes('revenge.deps') && + !(options?.uninitialized ?? false) + ) + DEBUG_warnFilterWithoutUninitialized(filter.key) + if (options?.cached ?? true) { const notInit = !(options?.initialize ?? true) @@ -464,3 +478,15 @@ function DEBUG_warnLookupNoMatch(key: string) { nativeLoggingHook(`\u001b[31mFailed lookup: ${key}\n${stack}\u001b[0m`, 2) } + +/** + * Warns the developer about a potentially bad filter for lookups that do not have uninitialized modules. + */ +function DEBUG_warnFilterWithoutUninitialized(key: string) { + const stack = getCurrentStack() + + nativeLoggingHook( + `\u001b[33mPotentially bad filter without uninitialized modules lookup: ${key}\n${stack}\u001b[0m`, + 2, + ) +}