SheWhoReignsSupreme/revenge-plugins
1
0
Fork 0
Code Issues 1 Pull requests 1 Projects Releases Packages Wiki Activity Actions

FakeProfileThemesAndEffects: effects picker rendered blank - ProfileEffectRecord needs raw config, not the {id,skuId,config} wrapper

Browse source
This commit is contained in:
Ally Founder 2026-08-10 22:20:01 -04:00
parent 9d71ccee39
commit 9021135dec
2 changed files with 10 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
plugins/fake-profile-themes-and-effects/src/patches/patchUseProfileEffectSections.ts
View file

@ -21,7 +21,7 @@ export const patchUseProfileEffectSections = () => useSectionModules.map(
origSections.splice(1);
origSections[0]!.items.splice(1);
profileEffectStore.profileEffects.forEach(effect => {
origSections[0]!.items.push(new ProfileEffectRecord(effect));
origSections[0]!.items.push(new ProfileEffectRecord(effect.config));
});
prevSections = origSections;
} else if (prevSections) {

12
plugins/fake-profile-themes-and-effects/src/ui/actionSheets/EffectPickerActionSheet.tsx
View file

@ -39,7 +39,11 @@ function PatchedEffectPickerActionSheet(props: EffectPickerActionSheetProps) {
const themeContext = useThemeContext();
const effectRecords = useMemo(() => effects.map(effect => ({ items: new ProfileEffectRecord(effect) })), [effects]);
// ProfileEffectRecord's fields mirror the raw shop config (skuId, title, thumbnailPreviewSrc,
// effects, ...) - confirmed live that constructing it from our {id, skuId, config} wrapper
// instead of effect.config leaves everything but skuId/type undefined, which is why the picker
// used to open with a fully empty effect list.
const effectRecords = useMemo(() => effects.map(effect => ({ items: new ProfileEffectRecord(effect.config) })), [effects]);
let isLegacyEffectPicker = false;
const effectPickerInner: RN.Element<any> | null = findElementInTree(tree, element => {
@ -93,7 +97,7 @@ function PatchedEffectPickerActionSheet(props: EffectPickerActionSheetProps) {
} else {
if (effectPickerInner.props.selectedProfileEffect === undefined)
effectPickerInner.props.setSelectedProfileEffect(currentEffectId
? new ProfileEffectRecord({ id: currentEffectId } as any)
? new ProfileEffectRecord({ skuId: currentEffectId } as any)
: null);
effectPickerInner.props.purchases = effectRecords;
}
@ -101,7 +105,9 @@ function PatchedEffectPickerActionSheet(props: EffectPickerActionSheetProps) {
setPreviewUserId(user.id);
applyButton.props.onPress = () => {
setPreviewUserId(undefined);
onSelect(effects.find(effect => effect.id === effectPickerInner.props.selectedProfileEffect?.id)?.config ?? null);
// selectedProfileEffect is a ProfileEffectRecord - confirmed live it has no .id field, only
// .skuId, so comparing against effect.id here always missed and onSelect got null every time.
onSelect(effects.find(effect => effect.skuId === effectPickerInner.props.selectedProfileEffect?.skuId)?.config ?? null);
};
return (lastGoodTree = tree) as ReactElement;