SheWhoReignsSupreme/revenge-plugins
1
0
Fork 0
Code Issues 1 Pull requests 1 Projects Releases Packages Wiki Activity Actions

ServerDrawer: fix getQuestAsset guard installing after the risky hooks, not before

Browse source
This commit is contained in:
Ally Founder 2026-08-11 08:22:49 -04:00
parent a81a3417f5
commit 8f845f6540
1 changed files with 23 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

36
plugins/server-drawer/src/patches/fakeQuestDock.ts
View file

@ -116,6 +116,29 @@ export function patchFakeQuestDock(cleanups: (() => void)[]): boolean {
return false;
}
// Found and patched first, before any of the render-forcing hooks below - confirmed live that
// this module's own registration timing is independent of useMobileQuestDock's, and the two
// used to be patched in the opposite order. That left a real window where the render-forcing
// hooks were already active but this safety net wasn't yet, and once those hooks got good
// enough at their job to actually reach render paths that call getQuestAsset, they reached one
// this plugin hadn't patched yet - "Cannot read property 'startsWith' of undefined" reaching an
// uncaught render crash despite the guard existing, just not soon enough. Retrying the whole
// function together until both are ready means the risky hooks never go live without their net.
const assetMod = rawFindByFunctionProps<any>("getQuestAsset");
if (!assetMod) {
console.log(TAG, "WARN: getQuestAsset not found yet (will retry)");
return false;
}
const origGetQuestAsset = assetMod.getQuestAsset;
assetMod.getQuestAsset = function (this: unknown, ...args: any[]) {
try {
return origGetQuestAsset.apply(this, args);
} catch {
return { url: null, isAnimated: false };
}
};
cleanups.push(() => { assetMod.getQuestAsset = origGetQuestAsset; });
const origUseMobileQuestDock = mod.useMobileQuestDock;
let cachedUserId: string | undefined;
mod.useMobileQuestDock = function (this: unknown, ...args: any[]) {
@ -153,19 +176,6 @@ export function patchFakeQuestDock(cleanups: (() => void)[]): boolean {
cleanups.push(() => { mod.useIsMobileQuestDockRenderedBase = origRenderedBase; });
}
const assetMod = rawFindByFunctionProps<any>("getQuestAsset");
if (assetMod) {
const origGetQuestAsset = assetMod.getQuestAsset;
assetMod.getQuestAsset = function (this: unknown, ...args: any[]) {
try {
return origGetQuestAsset.apply(this, args);
} catch {
return { url: null, isAnimated: false };
}
};
cleanups.push(() => { assetMod.getQuestAsset = origGetQuestAsset; });
}
console.log(TAG, "PATCH: fake Quest Dock fallback active");
return true;
}