SheWhoReignsSupreme/revenge-plugins
1
0
Fork 0
Code Issues 1 Pull requests 1 Projects Releases Packages Wiki Activity Actions

YouBar+: patch via createElement interception instead of module-property mutation, which stopped reliably reaching Discord's own render call

Browse source
This commit is contained in:
Ally Founder 2026-08-12 14:46:40 -04:00
parent 96eff341ce
commit 80cbcda934
2 changed files with 59 additions and 83 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

37
plugins/you-bar-plus/src/index.ts
View file

@ -5,31 +5,6 @@ import { setInboxTracking } from "./lib/notifications";
import Settings from "./ui/Settings";
let unpatchButtons: () => void = () => {};
let patched = false;
let retryHandle: ReturnType<typeof setInterval> | undefined;
function stopRetrying() {
if (retryHandle) {
clearInterval(retryHandle);
retryHandle = undefined;
}
}
// YouBarNotificationsButton isn't registered until YouBar itself has rendered at least once -
// retries on an interval until it lands.
function attempt() {
try {
const unpatch = patchYouBarButtons();
if (unpatch) {
unpatchButtons = unpatch;
patched = true;
stopRetrying();
}
} catch (e) {
logger.error(`[YouBar+] Failed to apply the "YouBar buttons" patch: ${e}`);
stopRetrying();
}
}
export default {
onLoad: () => {
@ -40,17 +15,13 @@ export default {
setInboxTracking(!!storage.showInboxButton);
attempt();
if (!patched) {
let ticks = 0;
retryHandle = setInterval(() => {
attempt();
if (++ticks >= 30) stopRetrying(); // ~9s at 300ms, then give up
}, 300);
try {
unpatchButtons = patchYouBarButtons();
} catch (e) {
logger.error(`[YouBar+] Failed to apply the "YouBar buttons" patch: ${e}`);
}
},
onUnload: () => {
stopRetrying();
unpatchButtons();
setInboxTracking(false);
},

105
plugins/you-bar-plus/src/patches/youBarButtons.tsx
View file

@ -1,18 +1,21 @@
import { findByProps, findByTypeName, findByName } from "@vendetta/metro";
import { findByProps, findByName } from "@vendetta/metro";
import { React } from "@vendetta/metro/common";
import { instead } from "@vendetta/patcher";
import { storage } from "@vendetta/plugin";
import { getAssetIDByName } from "@vendetta/ui/assets";
import { registerPropsTransform, patchCreateElement } from "@shared/lib/createElementIntercept";
import { registerTypeDetector, registerIntercept, registerPropsTransform, patchCreateElement } from "@shared/lib/createElementIntercept";
import NotificationCenter from "../ui/NotificationCenter";
// Retry logic lives one level up in index.ts, calling this repeatedly until it succeeds - keep
// this function itself simple.
export let updateYouBar = () => {};
/** Returns null (not undefined) when YouBarNotificationsButton isn't registered in Metro yet, so a caller can tell "not ready" apart from "patched, here's the unpatch fn". */
export default function patchYouBarButtons(): (() => void) | null {
const YouBarNotificationsButton = findByTypeName("YouBarNotificationsButton");
// findByTypeName + instead("type", ...) used to patch this, but that mutates whatever object
// Metro's search hands back - which isn't reliably the same reference Discord's own render call
// site reads from in this bundle (confirmed live: the property write didn't stick, and a fresh
// findByTypeName call moments later returned undefined). registerTypeDetector instead captures
// the exact type value at the actual createElement/jsx call site, so there's no reference
// mismatch to go stale.
export default function patchYouBarButtons(): () => void {
const userSettingsAction = findByProps("openUserSettings");
const transitionModule = findByProps("transitionToGuild");
@ -25,8 +28,6 @@ export default function patchYouBarButtons(): (() => void) | null {
const SettingsIcon = getAssetIDByName("SettingsIcon");
const ChatIcon = getAssetIDByName("ChatIcon");
if (!YouBarNotificationsButton) return null;
const openInbox = () => {
if (!Navigator || !Navigation?.push) {
console.error("[YouBar+] Inbox: Navigator not available");
@ -47,61 +48,65 @@ export default function patchYouBarButtons(): (() => void) | null {
));
};
const cleanups: (() => void)[] = [];
patchCreateElement(cleanups);
// The native bell is one of four sibling buttons YouBarNotificationsButton renders - the
// other three are unrelated icon buttons with raw numeric asset ids. accessibilityLabel is
// the only reliable way to pick the real bell out (confirmed live via the fiber tree), so
// this rewrites its onPress in place at element-creation time instead of guessing at res's
// shape - keeps the same native icon/styling, just repoints the tap when Inbox is enabled.
const elementCleanups: (() => void)[] = [];
patchCreateElement(elementCleanups);
// the only reliable way to pick the real bell out (confirmed live via the fiber tree).
registerPropsTransform(
(props) => !!storage.showInboxButton && props?.accessibilityLabel === "Notifications",
(props) => ({ ...props, onPress: openInbox }),
);
const unpatchType = instead("type", YouBarNotificationsButton, (args: any[], OriginalRender: (...a: any[]) => any) => {
const [, forceUpdate] = React.useReducer((x: number) => ~x, 0);
registerTypeDetector(
"you-bar-plus-notifications-button",
(type) => typeof type === "function" && type.name === "YouBarNotificationsButton",
(YouBarNotificationsButton: any) => {
const PatchedYouBarNotificationsButton = (props: any) => {
const [, forceUpdate] = React.useReducer((x: number) => ~x, 0);
updateYouBar = () => forceUpdate();
updateYouBar = () => forceUpdate();
const res = YouBarNotificationsButton(props);
const res = OriginalRender(...args);
if (!res?.props?.children) return res;
if (!res?.props?.children) return res;
const IconButton = res.props.children.type;
const originalProps = res.props.children.props;
const IconButton = res.props.children.type;
const originalProps = res.props.children.props;
return (
<React.Fragment>
{storage.showDMButton && (
<IconButton
variant={originalProps?.variant || "tertiary"}
size={originalProps?.size || "sm"}
icon={ChatIcon}
onPress={() => {
transitionModule?.transitionToGuild?.("@me");
}}
/>
)}
return (
<React.Fragment>
{storage.showDMButton && (
<IconButton
variant={originalProps?.variant || "tertiary"}
size={originalProps?.size || "sm"}
icon={ChatIcon}
onPress={() => {
transitionModule?.transitionToGuild?.("@me");
}}
/>
)}
{storage.showSettingsButton && (
<IconButton
variant={originalProps?.variant || "tertiary"}
size={originalProps?.size || "sm"}
icon={SettingsIcon}
onPress={() => {
userSettingsAction?.openUserSettings?.();
}}
/>
)}
{storage.showSettingsButton && (
<IconButton
variant={originalProps?.variant || "tertiary"}
size={originalProps?.size || "sm"}
icon={SettingsIcon}
onPress={() => {
userSettingsAction?.openUserSettings?.();
}}
/>
)}
{res}
</React.Fragment>
);
};
{res}
</React.Fragment>
);
});
registerIntercept(YouBarNotificationsButton, PatchedYouBarNotificationsButton);
},
{ persistent: true },
);
return () => {
unpatchType();
elementCleanups.forEach((fn) => fn());
};
return () => cleanups.forEach((fn) => fn());
}