SheWhoReignsSupreme/revenge-bundle-next
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix(lib/modules/finders): improve perf, correct docs

Browse source
This commit is contained in:
PalmDevs 2025-07-01 17:45:49 +07:00
parent e714960335
commit c239c5b4f8
No known key found for this signature in database
GPG key ID: 6FAE8F8677ACA8BA
2 changed files with 14 additions and 25 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
lib/modules/src/finders/get.ts
View file

@ -92,13 +92,15 @@ export function getModule(
} else
for (const [exports, id] of lookupModules(filter, options!)) {
callback(exports, id)
if (--max === 0) return noopFalse
max--
if (!max) return noopFalse
}
const unsub = waitForModules(
filter,
(exports, id) => {
if (--max === 0) unsub()
max--
if (!max) unsub()
callback(exports, id)
},
options!,

33
lib/modules/src/finders/lookup.ts
View file

@ -27,9 +27,7 @@ export interface BaseLookupModulesOptions<
/**
* Whether to include uninitialized modules in the lookup.
*
* Options that require modules to be initialized (eg. `returnNamespace`, `skipDefault`) will be ignored during uninitialized module ID lookup.
*
* **This will initialize any modules that match the filter and may cause unintended side effects.**
* **This will initialize any modules that match the exportsless filter and may cause unintended side effects.**
*
* @default false
*/
@ -116,6 +114,7 @@ export function* lookupModules(filter: Filter, options?: LookupModulesOptions) {
// Return early if previous lookup was a full lookup and no modules were found
if (reg === null) return
const noInitCached = !(options?.initializeCached ?? true)
const cached = new Set<Metro.ModuleID>()
if (reg)
@ -125,18 +124,11 @@ export function* lookupModules(filter: Filter, options?: LookupModulesOptions) {
let exports: Metro.ModuleExports | undefined
if (!isModuleInitialized(id)) {
if (!(options?.initializeCached ?? true)) continue
if (noInitCached) continue
exports = __r(id)
}
} else exports = getInitializedModuleExports(id)
yield [
exportsFromFilterResultFlag(
flag,
(exports ??= getInitializedModuleExports(id)),
options,
),
id,
]
yield [exportsFromFilterResultFlag(flag, exports, options), id]
}
if (options?.includeInitialized ?? true)
@ -203,6 +195,8 @@ export function lookupModule(filter: Filter, options?: LookupModulesOptions) {
// Return early if previous lookup was a full lookup and no modules were found
if (reg === null) return []
const noInitCached = !(options?.initializeCached ?? true)
if (reg)
for (const sId in reg) {
const flag = reg[sId]
@ -210,18 +204,11 @@ export function lookupModule(filter: Filter, options?: LookupModulesOptions) {
let exports: Metro.ModuleExports
if (!isModuleInitialized(id)) {
if (!(options?.initializeCached ?? true)) continue
if (noInitCached) continue
exports = __r(id)
}
} else exports = getInitializedModuleExports(id)
return [
exportsFromFilterResultFlag(
flag,
(exports ??= getInitializedModuleExports(id)),
options,
),
id,
]
return [exportsFromFilterResultFlag(flag, exports, options), id]
}
if (options?.includeInitialized ?? true)