From bb7b480e6ba7b3246a54b8fc582dee128217ff24 Mon Sep 17 00:00:00 2001 From: Rosie Val Date: Sat, 8 Aug 2026 23:27:35 -0400 Subject: [PATCH] Emit errored events for plugin native and JS errors --- lib/plugins/src/_internal/index.ts | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/lib/plugins/src/_internal/index.ts b/lib/plugins/src/_internal/index.ts index aa8a54a..3dce517 100644 --- a/lib/plugins/src/_internal/index.ts +++ b/lib/plugins/src/_internal/index.ts @@ -309,8 +309,7 @@ registerJSMethod( const meta = getInternalPluginMeta(plugin) meta.nativeErrors = Object.freeze(errors) - // TODO: Do we need an errored event specifically? - // Nudge open UI to re-render the errors row + pEmitter.emit('errored', plugin, errors) pEmitter.emit('flagUpdate', plugin) }, ) @@ -577,9 +576,7 @@ export function isPluginStartable(plugin: AnyPlugin): boolean { */ export async function handlePluginError(e: unknown, plugin: AnyPlugin) { ;(plugin.errors as unknown[]).push(e) - - // TODO: Emit errored event so UI can update? - // Update: errored event removed (but status changes are still emitted), so UI should update fine + pEmitter.emit('errored', plugin, e) nativeLoggingHook( `\u001b[31mPlugin "${plugin.manifest.id}" encountered an error: ${