From 5543030b5769c554ba5aa4e95f64d3e488824c01 Mon Sep 17 00:00:00 2001 From: PalmDevs Date: Fri, 18 Jul 2025 02:04:54 +0700 Subject: [PATCH] fix(plugins/developer-settings): missing icon in React DevTools error toast --- .../start/developer-settings/react-devtools.ts | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/src/plugins/start/developer-settings/react-devtools.ts b/src/plugins/start/developer-settings/react-devtools.ts index a87ae05..fae7c9b 100644 --- a/src/plugins/start/developer-settings/react-devtools.ts +++ b/src/plugins/start/developer-settings/react-devtools.ts @@ -24,13 +24,6 @@ const events = new TypedEventEmitter<{ errored: [unknown] }>() -// TODO(PalmDevs): This currently returns undefined because it is ran too early -const CircleXIcon = lookupGeneratedIconComponent( - 'CircleXIcon', - 'CircleXIcon-secondary', - 'CircleXIcon-primary', -) - export function connect() { if (!RDTContext.active || RDTContext.ws) return @@ -55,7 +48,12 @@ export function connect() { ToastActionCreators.open({ key: 'REACT_DEVTOOLS_ERROR', - IconComponent: CircleXIcon, + // TODO(PalmDevs): declare this on top of file once asset cache can be loaded earlier + IconComponent: lookupGeneratedIconComponent( + 'CircleXIcon', + 'CircleXIcon-secondary', + 'CircleXIcon-primary', + ), content: err, }) })