diff --git a/lib/plugins/src/_internal/index.ts b/lib/plugins/src/_internal/index.ts index c9b0140..db0b4ae 100644 --- a/lib/plugins/src/_internal/index.ts +++ b/lib/plugins/src/_internal/index.ts @@ -289,9 +289,10 @@ registerJSMethod( if (!plugin) return const meta = getInternalPluginMeta(plugin) - if (meta) { - meta.nativeErrors = Object.freeze(errors) - } + meta.nativeErrors = Object.freeze(errors) + // TODO: Do we need an errored event specifically? + // Nudge open UI to re-render the errors row + pEmitter.emit('flagUpdate', plugin) }, ) diff --git a/src/plugins/start/settings.plugins/components/PluginInstallConfirmAlert.tsx b/src/plugins/start/settings.plugins/components/PluginInstallConfirmAlert.tsx index 462122e..dc06c4a 100644 --- a/src/plugins/start/settings.plugins/components/PluginInstallConfirmAlert.tsx +++ b/src/plugins/start/settings.plugins/components/PluginInstallConfirmAlert.tsx @@ -31,16 +31,12 @@ export default function PluginInstallConfirmAlert({ { - confirmInstall(prompt.token, true) - }} + onPress={() => confirmInstall(prompt.token, true)} /> { - confirmInstall(prompt.token, false) - }} + onPress={() => confirmInstall(prompt.token, false)} /> } diff --git a/src/plugins/start/settings.plugins/utils/actions.tsx b/src/plugins/start/settings.plugins/utils/actions.tsx index e037ab1..2e0a7b1 100644 --- a/src/plugins/start/settings.plugins/utils/actions.tsx +++ b/src/plugins/start/settings.plugins/utils/actions.tsx @@ -64,8 +64,9 @@ export async function handleEnablePlugin(plugin: AnyPlugin) { try { await enablePlugin(plugin) } catch (e) { - // Requirements not satisfied by native + // Requirements not satisfied by native, don't try to start showErrorToast(messageOf(e)) + return } await runPluginLate(plugin).catch(noop)