SheWhoReignsSupreme/GoonXposed
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix(modules/UpdaterModule): actually fix memory leak correctly

Browse source
This commit is contained in:
PalmDevs 2025-10-12 03:00:15 +07:00
parent b0fd423863
commit 90ecc5fd2e
No known key found for this signature in database
GPG key ID: 6FAE8F8677ACA8BA
1 changed files with 10 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
app/src/main/kotlin/io/github/revenge/xposed/modules/UpdaterModule.kt
View file

@ -21,6 +21,7 @@ import io.ktor.http.*
import kotlinx.coroutines.*
import kotlinx.serialization.Serializable
import java.io.File
import java.lang.ref.WeakReference
@Serializable
data class CustomLoadUrl(
@ -40,6 +41,7 @@ data class LoaderConfig(
object UpdaterModule : Module() {
private lateinit var config: LoaderConfig
private val scope = CoroutineScope(SupervisorJob() + Dispatchers.IO)
private var lastActivity: WeakReference<Activity>? = null
private lateinit var cacheDir: File
private lateinit var bundle: File
@ -128,11 +130,17 @@ object UpdaterModule : Module() {
}
} catch (e: Throwable) {
Log.e("Failed to download script", e)
if (activity != null) showErrorDialog(e, activity)
showErrorDialog(e)
}
}
fun showErrorDialog(e: Throwable, activity: Activity) {
override fun onActivity(activity: Activity) {
lastActivity = WeakReference(activity)
}
fun showErrorDialog(e: Throwable) {
val activity = lastActivity?.get() ?: return
activity.runOnUiThread {
AlertDialog.Builder(activity).setTitle("Revenge Update Failed").setMessage(
"""