Commit graph

18 commits

Author SHA1 Message Date
V
2f1c6a37fc
fix many bugs found by Claude (#4436)
Fixes:
- Webpack Patcher: incorrect patch error handling could lead to some functional patches not being applied 
- CommandsAPI: subcommands were impossible to unregister
- useAwaiter: on error, the value was set to null even if a fallbackValue was specified, violating the type contract
- Patcher: build check boolean logic was grouped incorrectly due to missing parantheses
- CustomCommands: commands weren't unregistered on stop, leading to error when enabling, disabling & re-renabling the plugin
- Notification Log: delete was by timestamp instead of ID and non-atomic
- FixSpotifyEmbeds: settings listener was registered inside browser-window-created event handler, leading to duplicate listeners
- CustomRPC: changing activity type or timestamp didn't update the RPC
- CopyStickerLinks: message patch had non-sense code, just removed it
- XSOverlay: UDP socket wasn't closed on stop
- VoiceMessages: Web recorder never closed the mic media stream, which continues showing the OS mic indicator
- PictureInPicture: Video clone wasn't properly cleaned up, which leaked memory
- Themes (Extension version): theme object urls were never cleaned up, which leaked memory on theme change
- Themes (Extension version): Upload Theme button hitbox was only the text, not the whole button. Also added Drag & Drop from file manager support
- Dearrow: toggling for one embed flipped the global dearrow by default setting
- Extension Installer: the zip extract function was vulnerable to path traversal, although we only ever used this for React DevTools obtained via https so it has low impact
- FileWatchers: ensure always properly cleaned up
- components/Link: mutated props which is a very bad practice

All fixes are human written, only the audit was done by Claude Fable (thanks for ur tokens, Zere).
2026-07-26 17:07:47 +02:00
V
dc9064326b
refactor discord types into separate npm package (#3520)
Co-authored-by: V <vendicated@riseup.net>
Co-authored-by: sadan <117494111+sadan4@users.noreply.github.com>
Co-authored-by: ezzud <contact@ezzud.fr>
2025-07-10 00:38:39 +02:00
sadan4
7eec2e5d5b
CommandsAPI: Fix issue with overlapping IDS (#3271) 2025-03-21 12:33:37 +00:00
Etorix
dd87f360d7
CommandsAPI: Fix spread overwriting omitted subcommand options (#3057) 2024-12-03 02:13:27 +00:00
Vendicated
8890c8c6b4
fix Commands, Badges, RoleColorEverywhere 2024-09-05 02:35:40 +02:00
Haruka
99cd423efb
fix crashing on canary when searching slash commands (#2844) 2024-09-04 23:26:08 +02:00
Vendicated
0d5e2d0696
[skip ci] Refactor utils 2023-05-06 01:36:00 +02:00
Mufaro
9c929a4d98
messageTags: Fix duplicate entries & replies (#922)
Co-authored-by: V <vendicated@riseup.net>
2023-04-16 23:44:33 +00:00
Ven
bad96b7887
Path aliases, better lazyWebpack (#268) 2022-11-28 13:37:55 +01:00
Vendicated
8f2c247f27
Fix commands showing up multiple times Part 2 2022-11-18 23:31:53 +01:00
Vendicated
43f41d20fa
Fix commands showing up multiple times 2022-11-18 23:29:34 +01:00
Ven
d72542405a
Implement Subcommands; fix errors due to Settings <-> Plugins circular imports (#174) 2022-10-29 20:45:31 +02:00
Ven
5fac8be0ae
Vencord Standalone without git/node (#148) 2022-10-23 23:23:52 +02:00
Vendicated
61fd38d6d9
style: Sort imports 2022-10-22 18:18:41 +02:00
Vendicated
f92f3f1a5e
Add license headers 2022-10-22 01:17:14 +02:00
Vendicated
05051399b6 Fix error when enabling a plugin with commands if CommandsAPI hasn't loaded 2022-10-20 20:23:14 +02:00
Mai
2cb6c23347
add choices to CommandsAPI Options (#94) 2022-10-14 13:21:44 +02:00
Vendicated
267b2b1a07
Commands: basic error handling 2022-10-12 22:22:21 +02:00